Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pool): blobstore cluster size to be set during pool creation through grpc parameter value #83

Merged
merged 1 commit into from
Oct 4, 2023
Merged

feat(pool): blobstore cluster size to be set during pool creation through grpc parameter value #83

merged 1 commit into from
Oct 4, 2023

Conversation

hrudaya21
Copy link
Contributor

  • The default cluster size considered by SPDK is 4MiB.
  • During pool creation, cluster_size can be taken from the gRPC and consider that value.
  • The cluster_size can be consider with multiple of 4MiB.
  • If the cluster_size passed not multiple of 1MiB, then default 4MiB cluster size will be considered for the pool creation.

dsavitskiy
dsavitskiy suggested changes Sep 29, 2023
View reviewed changes
protobuf/v1/pool.proto Outdated Show resolved Hide resolved
protobuf/v1/pool.proto Outdated Show resolved Hide resolved
@dsharma-dc
Copy link
Contributor

dsharma-dc commented Sep 29, 2023 •
edited
Loading

btw, I haven't checked by getting the runtime config, but the spdk documentation says the default cluster size is 1MB, so you might want to modify comments and description. Has to be multiple of page size(typically 4096 bytes / 4KiB)

Cluster Size: By default, this value is 1MB.

@tiagolobocastro tiagolobocastro merged commit 3365ab9 into openebs-archive:develop Oct 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@dsharma-dc dsharma-dc dsharma-dc left review comments

@dsavitskiy dsavitskiy dsavitskiy approved these changes

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hrudaya21 @dsharma-dc @dsavitskiy @tiagolobocastro @Abhinandan-Purkait